[libcxx-commits] [PATCH] D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 24 10:44:44 PST 2022


Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM!



================
Comment at: libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.assign/unique_ptr_Y.pass.cpp:129
+#ifdef _LIBCPP_VERSION // Bogus test cases assign unique_ptr<Y> to shared_ptr<T> despite that
+                       // Y* and T* are not compatible per [util.smartptr.shared.general]/6.
     {
----------------
Thanks for filing a bug report! Can you add a link to the bug in the comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117996/new/

https://reviews.llvm.org/D117996



More information about the libcxx-commits mailing list