[libcxx-commits] [PATCH] D117918: [libc++][test] Add const and reference tests for enable_view

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 21 12:34:42 PST 2022


Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/ranges/range.req/range.view/enable_view.compile.pass.cpp:46
+static_assert(!std::ranges::enable_view<EnableViewFalse&&>);
+static_assert(std::ranges::enable_view<const EnableViewFalse>);
+static_assert(!std::ranges::enable_view<const EnableViewFalse&>);
----------------
philnik wrote:
> This seems weird. It looks to me like the standard requires it that way, but I don't know why.
Yikes. Good catch. This reminds me of D116388, but unlike `bind`, this stuff is so new that I think this deserves an LWG issue. I'll request one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117918/new/

https://reviews.llvm.org/D117918



More information about the libcxx-commits mailing list