[libcxx-commits] [PATCH] D117918: [libc++][test] Add const and reference tests for enable_view

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Thanks! This is an improvement as-is, but I think you should consider merging //all// your new tests from D117714 <https://reviews.llvm.org/D117714> into this review. They should all work today, because `view_interface<T>` already inherits from `view_base`. Then your D117714 <https://reviews.llvm.org/D117714> will become a code-only change, with no diffs to any of the tests except for the empty-base-sizeof test (and I guess if merging the tests over here discovers any bugs in the existing implementation!).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117918/new/

https://reviews.llvm.org/D117918