[libcxx-commits] [PATCH] D117537: [cmake] Duplicate `{llvm, compiler_rt}_check_linker_flag` for runtime libs and llvm

John Ericson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 20 16:06:30 PST 2022


Ericson2314 added a comment.

Perhaps the difference betwen `CMAKE_EXE_LINKER_FLAGS` and `CMAKE_REQUIRED_FLAGS` is important? Also, if it is not possible to link until these libraries are built (e.g. in a cross setting) maybe I am not sure what happens.

If it was neessary these flags aren't just checked re linking, maybe we need to make a similar compat wrapper around https://cmake.org/cmake/help/latest/module/CheckCompilerFlag.html and use that instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537



More information about the libcxx-commits mailing list