[libcxx-commits] [PATCH] D117537: [cmake] Duplicate `{llvm, compiler_rt}_check_linker_flag` for runtime libs and llvm

[Leonard Chan via Phabricator via libcxx-commits]

leonardchan added a comment.

Hi, I suspect that this patch (or D117815 <https://reviews.llvm.org/D117815>) led to the build failure we're seeing on our builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8824480583333895809):

  CMake Error at /b/s/w/ir/x/w/llvm-llvm-project/libunwind/src/CMakeLists.txt:99 (message):
    Compiler doesn't support generation of unwind tables if exception support
    is disabled.  Building libunwind DSO with runtime dependency on C++ ABI
    library is not supported.
  
  
  -- Configuring incomplete, errors occurred!
  See also "/b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-fuchsia+asan-bins/CMakeFiles/CMakeOutput.log".
  See also "/b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-fuchsia+asan-bins/CMakeFiles/CMakeError.log".
  FAILED: runtimes/runtimes-x86_64-unknown-fuchsia+asan-stamps/runtimes-x86_64-unknown-fuchsia+asan-configure /b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-fuchsia+asan-stamps/runtimes-x86_64-unknown-fuchsia+asan-configure 

Maybe @phosek knows if we're missing something like a cmake flag on our end or if there's something in this patch causing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117537/new/

https://reviews.llvm.org/D117537