[libcxx-commits] [PATCH] D117820: Revert "[libc++] [test] UNSUPPORTED my new uniform_int_distribution test on MinGW."

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

I had a look, and it seems to run correctly when built with a recent Clang 14 snapshot. But with Clang 13.0.0 as in the CI, it crashes.

The crash backtrace looks like this:

  #0  0x00007ff6a3c107f7 in __floattidf ()
  #1  0x00007ff6a3c0c42a in double std::__1::accumulate<std::__1::__wrap_iter<__int128*>, double>(std::__1::__wrap_iter<__int128*>, std::__1::__wrap_iter<__int128*>, double) ()
  #2  0x00007ff6a3bf3a2f in void test_statistics<__int128, std::__1::linear_congruential_engine<unsigned int, 16807u, 0u, 2147483647u> >(__int128, __int128) ()
  #3  0x00007ff6a3bf3303 in void test_statistics<__int128, std::__1::linear_congruential_engine<unsigned int, 16807u, 0u, 2147483647u> >() ()
  #4  0x00007ff6a3bf1526 in main ()

Therefore, I think the fix for this bug, that already is present in Clang 14, probably is this one: https://reviews.llvm.org/D110413.

So I guess if we wanted to, we could change this into `XFAIL: target={{.+}}-windows-gnu && clang-13`, to have the test automatically taken into use when we upgrade the CI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117820/new/

https://reviews.llvm.org/D117820