[libcxx-commits] [PATCH] D117820: Revert "[libc++] [test] UNSUPPORTED my new uniform_int_distribution test on MinGW."

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 20 11:22:42 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: mstorsjo, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

In 5820322cb1cb9df5f05a49ed9d86984c0ac7d28d <https://reviews.llvm.org/rG5820322cb1cb9df5f05a49ed9d86984c0ac7d28d> I marked this test UNSUPPORTED on MinGW to fix a CI failure, but //why// it fails on MinGW is still a mystery to me. Hoping @mstorsjo or somebody can help figure it out.
In that commit, I had written:

> After 9fe67486cc <https://reviews.llvm.org/rG9fe67486cc06a02308a169a33ecbbf841017a27d>, this test fails on MinGW for some reason.
> https://buildkite.com/llvm-project/libcxx-ci/builds/7922#9e267294-441d-4b79-8a19-30fdb5599c1f
> All it says in the build output is
>
>   note: command had no output on stdout or stderr
>   error: command failed with exit status: 4294967295


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117820

Files:
  libcxx/test/std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp


Index: libcxx/test/std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp
===================================================================
--- libcxx/test/std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp
+++ libcxx/test/std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp
@@ -7,9 +7,6 @@
 //===----------------------------------------------------------------------===//
 //
 // REQUIRES: long_tests
-//
-// This fails on MinGW for some unknown reason.
-// UNSUPPORTED: target={{.+}}-windows-gnu
 
 // <random>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117820.401714.patch
Type: text/x-patch
Size: 578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220120/380d3aa3/attachment-0001.bin>


More information about the libcxx-commits mailing list