[libcxx-commits] [PATCH] D117417: [libcxx][libcxxabi][libunwind][cmake] Use `GNUInstallDirs` to support custom installation dirs

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added inline comments.


================
Comment at: libcxx/CMakeLists.txt:32
 if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR LIBCXX_STANDALONE_BUILD)
   project(libcxx CXX C)
 
----------------
arichardson wrote:
> Shouldn't this be included below `project()` to avoid cmake warnings?
Sorry, I did see this and your earlier comment in https://reviews.llvm.org/D100810#3248494 .

If it's OK, I figured I might want to come up with a systematic solution later. Relatedly, we are not yet using `CMAKE_INSTALL_LIBDIR` because of `LLVM_LIBDIR_SUFFIX` and friends.

I think the solution might end being custom logic to default `CMAKE_INSTALL_LIBDIR` if it is not yet defined, and then we side-step the warning entirely?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117417/new/

https://reviews.llvm.org/D117417