[libcxx-commits] [PATCH] D117417: [libcxx][libcxxabi][libunwind][cmake] Use `GNUInstallDirs` to support custom installation dirs

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 18 00:50:09 PST 2022


arichardson added inline comments.


================
Comment at: libcxx/CMakeLists.txt:32
 if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR LIBCXX_STANDALONE_BUILD)
   project(libcxx CXX C)
 
----------------
Shouldn't this be included below `project()` to avoid cmake warnings?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117417/new/

https://reviews.llvm.org/D117417



More information about the libcxx-commits mailing list