[libcxx-commits] [PATCH] D117434: [libc++] [test] Improve the tests for std::assignable_from

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with nitpick comment.



================
Comment at: libcxx/test/std/concepts/concepts.lang/concept.assignable/assignable_from.compile.pass.cpp:12
 
-// template<class From, class To>
-// concept assignable_from;
+// template< class LHS, class RHS >
+// concept assignable_from =
----------------
We've never done it that way, and I don't think we should start now.


================
Comment at: libcxx/test/std/concepts/concepts.lang/concept.assignable/assignable_from.compile.pass.cpp:442
-
-namespace StandardTypes {
-static_assert(
----------------
Some of the complexity in this test comes from the fact that we're doing conformance testing for several standard types, which is something I had required when we first started working on concepts. In retrospect, I think the complexity/value tradeoff of these tests is not as high as I thought.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117434/new/

https://reviews.llvm.org/D117434