[libcxx-commits] [PATCH] D117434: [libc++] [test] Improve the tests for std::assignable_from

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, Mordante, libc++.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Fixes https://github.com/llvm/llvm-project/issues/50060 .
Looking into this file gave me a wtf moment. So I rewrote this whole test so that it actually tests the stuff we're trying to test. For each subexpression of the concept, test what happens when it fails. Also, test some types that mimic weird standard types, such as `std::locale` (returns by const reference) and `std::tuple`-of-references.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117434

Files:
  libcxx/test/std/concepts/concepts.lang/concept.assignable/assignable_from.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117434.400391.patch
Type: text/x-patch
Size: 32459 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220116/d61f258b/attachment-0001.bin>