[libcxx-commits] [PATCH] D117397: [libc++] [test] Use hidden friends consistently in the test iterators

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Jan 15 09:31:53 PST 2022


Quuxplusone updated this revision to Diff 400299.
Quuxplusone marked an inline comment as done.
Quuxplusone added a comment.

Fix the C++03 test failure (`reverse_iterator`'s `operator-` is not SFINAEd away in C++03 mode).
`non_default_constructible_iterator` is redundant and should be removed entirely, but I'll make a separate PR for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117397/new/

https://reviews.llvm.org/D117397

Files:
  libcxx/test/std/iterators/predef.iterators/move.iterators/move.iter.ops/move.iter.op.const/convert.pass.cpp
  libcxx/test/std/iterators/predef.iterators/move.iterators/move.iter.ops/move.iter.op=/move_iterator.pass.cpp
  libcxx/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.cons/assign.pass.cpp
  libcxx/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.cons/ctor.reverse_iterator.pass.cpp
  libcxx/test/std/iterators/predef.iterators/reverse.iterators/reverse.iter.nonmember/minus.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
  libcxx/test/support/test_iterators.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117397.400299.patch
Type: text/x-patch
Size: 33258 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220115/46d7676f/attachment-0001.bin>


More information about the libcxx-commits mailing list