[libcxx-commits] [PATCH] D117397: [libc++] [test] Use hidden friends consistently in the test iterators

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

LGTM % comment



================
Comment at: libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp:26225
-    output_iterator<char*> iter;
     std::locale lc = std::locale::classic();
     std::locale lg(lc, new my_numpunct);
----------------
Not in this PR, but maybe this test should be split into multiple tests? 26k lines might be a bit to long.


================
Comment at: libcxx/test/support/test_iterators.h:132
 
-    TEST_CONSTEXPR_CXX14 It base() const {return it_;}
+    TEST_CONSTEXPR It base() const {return it_;} // TODO remove me
 
----------------
Please put this below `operator!=` to be consistent with the others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117397/new/

https://reviews.llvm.org/D117397