[libcxx-commits] [PATCH] D117367: [libcxx][test] Niebloids are not portably of `final` class type

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added a comment.
This revision now requires changes to proceed.

I believe this is obsolete since D116384 <https://reviews.llvm.org/D116384>: all uses of `is_niebloid` are now guarded under `LIBCPP_STATIC_ASSERT` at their call sites. E.g.

  LIBCPP_STATIC_ASSERT(is_niebloid<decltype(std::ranges::prev)>());

That was the superior solution, because actually it's IFNDR even to try to compute `decltype(std::ranges::prev)` — overload sets don't have decltypes.
Recommend abandoning this.

See also D116570 <https://reviews.llvm.org/D116570>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117367/new/

https://reviews.llvm.org/D117367