[libcxx-commits] [PATCH] D117367: [libcxx][test] Niebloids are not portably of `final` class type

Casey Carter via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 14 16:25:09 PST 2022


CaseyCarter created this revision.
CaseyCarter added reviewers: libc++, cjdb, Quuxplusone.
CaseyCarter added a project: libc++.
CaseyCarter requested review of this revision.
Herald added 1 blocking reviewer(s): libc++.

... nor any of the other things tested by `is_function_like`, to be fair, but they pass with MSVC STL so :shrug:.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117367

Files:
  libcxx/test/support/is_niebloid.h


Index: libcxx/test/support/is_niebloid.h
===================================================================
--- libcxx/test/support/is_niebloid.h
+++ libcxx/test/support/is_niebloid.h
@@ -31,7 +31,7 @@
   static_assert(!std::assignable_from<X&, X const>);
   static_assert(!std::assignable_from<X&, X&>);
   static_assert(!std::assignable_from<X&, X const&>);
-  static_assert(std::is_final_v<X>);
+  LIBCPP_STATIC_ASSERT(std::is_final_v<X>);
   return true;
 }
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117367.400186.patch
Type: text/x-patch
Size: 471 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220115/503ccc70/attachment-0001.bin>


More information about the libcxx-commits mailing list