[libcxx-commits] [PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

Thu Jan 13 05:52:38 PST 2022

koakuma added a comment.

In D116857#3238505 <https://reviews.llvm.org/D116857#3238505>, @MaskRay wrote:

> Just ignore it. The clang-format diagnostic is more useful for files conforming to the style or new files. For existing files violating it, it is sometimes better to leave it.

I see, thanks.

================
Comment at: libunwind/src/libunwind.cpp:70
 # warning The MIPS architecture is not supported with this ABI and environment!
+#elif defined(__sparc__) && defined(__arch64__)
+# define REGISTER_KIND Registers_sparc64
----------------
MaskRay wrote:
> `__sparc64__` or `__sparcv9__`?
`__sparc64__` and `__sparcv9__` are clang-only, it seems. GCC doesn't define any of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857