[libcxx-commits] [PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay added a comment.

In D116857#3231382 <https://reviews.llvm.org/D116857#3231382>, @koakuma wrote:

> I have a question about the code formatting suggestions. I worked on this following the original code's style (indentation, C-style casts, etc) but it looks like clang-format doesn't like it.
> Should I revise it following clang-format's suggestion, or is there a more proper way to go with it?

Just ignore it. The clang-format diagnostic is more useful for files conforming to the style or new files. For existing files violating it, it is sometimes better to leave it.



================
Comment at: libunwind/src/libunwind.cpp:70
 # warning The MIPS architecture is not supported with this ABI and environment!
+#elif defined(__sparc__) && defined(__arch64__)
+# define REGISTER_KIND Registers_sparc64
----------------
`__sparc64__` or `__sparcv9__`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857