[libcxx-commits] [PATCH] D116957: [libc++] [test] Add a test for proper _Uglification of template parameter names

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 12 23:38:02 PST 2022


mstorsjo added inline comments.


================
Comment at: libcxx/utils/libcxx/test/config.py:292
-        if self.cxx_stdlib_under_test != 'libstdc++' and \
-           not self.target_info.is_windows() and \
-           not self.target_info.is_zos():
----------------
FWIW it seems like this the nasty headers include file hasn't been in use at all on Windows so far (either in the legacy config or in the new standalone config files) - even if the old config file used to have some annotations for it... So it might be ok to just mark the test as unsupported on Windows for now, if you don't want to try to navigate through and figure out which other defines need to be skipped.

(I guess I could give that a shot too.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116957/new/

https://reviews.llvm.org/D116957



More information about the libcxx-commits mailing list