[libcxx-commits] [PATCH] D116957: [libc++] [test] Add a test for proper _Uglification of template parameter names

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D116957#3238946 <https://reviews.llvm.org/D116957#3238946>, @Quuxplusone wrote:

> https://buildkite.com/llvm-project/libcxx-ci/builds/7765
>
>   c:\llvm-mingw\include\wchar.h:241:31: error: expected ')'
>     int __cdecl iswalpha(wint_t _C);
>                                 ^
>
> @mstorsjo perhaps: Do you think `#ifndef _WIN32` is the right way to catch both MinGW and clang-cl, without catching anything else?

Yep, that's the most canonical way of identifying Windows as a platform.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116957/new/

https://reviews.llvm.org/D116957