[libcxx-commits] [PATCH] D117023: [libc++] [test] Remove clang-format comments from generated files. NFC.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, libc++.
Quuxplusone added a project: libc++.
Herald added subscribers: arphaman, kristof.beyls, arichardson.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

These files are auto-generated and will never be clang-formatted, so the comments are just noise.
Meanwhile they introduce a moral hazard, that new contributors see all these clang-format comments in the repo and think they set a precedent for clang-format comments in *non*-generated parts of the codebase.

(I propose also two followups: one to remove clang-format comments from the human-written parts of the codebase, and one to disable the `check-format` step in `libcxx/utils/ci/run-buildbot` — it seems to be causing vastly more harm than benefit.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117023

Files:
  libcxx/include/version
  libcxx/test/libcxx/double_include.sh.cpp
  libcxx/test/libcxx/inclusions/algorithm.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/array.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/bitset.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/chrono.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/cinttypes.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/complex.h.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/coroutine.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/deque.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/filesystem.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/forward_list.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/ios.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/iostream.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/iterator.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/list.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/map.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/memory.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/optional.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/queue.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/random.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/ranges.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/regex.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/set.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/stack.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/string.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/string_view.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/system_error.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/tgmath.h.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/thread.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/tuple.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/typeindex.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/unordered_map.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/unordered_set.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/utility.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/valarray.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/variant.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/vector.inclusions.compile.pass.cpp
  libcxx/test/libcxx/min_max_macros.compile.pass.cpp
  libcxx/test/libcxx/no_assert_include.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/any.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/array.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/format.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/list.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/map.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/memory.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/mutex.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/new.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/numbers.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/numeric.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/optional.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/ostream.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/queue.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/ranges.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/regex.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/scoped_allocator.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/semaphore.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/set.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/shared_mutex.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/span.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/stack.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/string.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/string_view.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/thread.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/tuple.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/type_traits.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/typeinfo.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/unordered_map.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/unordered_set.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/utility.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/variant.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/vector.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp
  libcxx/utils/generate_feature_test_macro_components.py
  libcxx/utils/generate_header_inclusion_tests.py
  libcxx/utils/generate_header_tests.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117023.398938.patch
Type: text/x-patch
Size: 53967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220111/25f2d624/attachment-0001.bin>