[libcxx-commits] [PATCH] D117023: [libc++] [test] Remove clang-format comments from generated files. NFC.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D117023#3234582 <https://reviews.llvm.org/D117023#3234582>, @Mordante wrote:

> Before we start doing this I prefer to first discuss what we want to do with clang-format. I really like to use it, even when it's not always perfect it's more consistent than human formatted code.

I strongly disagree that clang-format is "more consistent"; generally what we find is that taking clang-format's advice produces //inconsistencies// within the codebase. However, I suggest that at some point we should all get together and have a meeting about this issue, because it continues to be a source of friction over and over with new contributors.

> I really dislike removing the 3 `clang-format off` markers from human edited code. I added them for a good reason.

Can you clarify what you mean here? There's no human-edited code in this PR, except for the Python generators themselves. All the .cpp files touched in this PR are maintained via the Python scripts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117023/new/

https://reviews.llvm.org/D117023