[libcxx-commits] [PATCH] D116947: [libc++] Introduce __debug_db_insert_c()

Mon Jan 10 15:57:38 PST 2022

philnik added inline comments.

================
Comment at: libcxx/include/__debug:15
 #include <iosfwd>
+#include <type_traits>

----------------
Quuxplusone wrote:
> Is this for `__libcpp_is_constant_evaluated`? Might it make sense to move `__libcpp_is_constant_evaluated` into `<__config>`?
Yes. But I don't think it should be in `<__config>`. It's not really a config. Maybe in something like `__type_traits/is_contant_evaulated.h`?

================
Comment at: libcxx/include/__debug:273
+template <class _Tp>
+_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 inline void __debug_db_insert_c(_Tp* __c) {
+#if _LIBCPP_DEBUG_LEVEL == 2
----------------
Quuxplusone wrote:
> and perhaps `_LIBCPP_ALWAYS_INLINE` as we discussed? (I'm still neutral/ambivalent — seems like an easy but also maybe negligible win.)
I'd like to hear what @ldionne thinks about this. I'm not really sold on the idea unless we have some general guidelines when to use `_LIBCPP_ALWAYS_INLINE` or something similar.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116947/new/

https://reviews.llvm.org/D116947