[libcxx-commits] [PATCH] D116947: [libc++] Introduce __debug_db_insert_c()

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__debug:15
 #include <iosfwd>
+#include <type_traits>
 
----------------
Is this for `__libcpp_is_constant_evaluated`? Might it make sense to move `__libcpp_is_constant_evaluated` into `<__config>`?


================
Comment at: libcxx/include/__debug:273
+template <class _Tp>
+_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX11 inline void __debug_db_insert_c(_Tp* __c) {
+#if _LIBCPP_DEBUG_LEVEL == 2
----------------
and perhaps `_LIBCPP_ALWAYS_INLINE` as we discussed? (I'm still neutral/ambivalent — seems like an easy but also maybe negligible win.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116947/new/

https://reviews.llvm.org/D116947