[libcxx-commits] [PATCH] D116873: [libunwind][cmake] Create `LIBUNWIND_INSTALL_INCLUDE_DIR` CACHE PATH

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 added inline comments.


================
Comment at: libunwind/CMakeLists.txt:160
+set(LIBUNWIND_INSTALL_RUNTIME_DIR bin CACHE PATH
+    "Path where built libunwind runtime libraries should be installed.")
 
----------------
compnerd wrote:
> Perhaps it makes sense to use `CMAKE_INSTALL_INCLUDEDIR` and `CMAKE_INSTALL_BINDIR` to initialize the values?  That will allow the standard configuration paths to fold into this.  We could make these "advanced" and encourage users to prefer those (but retain these for the runtimes build configuration).
I was saving that for the original D99484. I've been told baby step patches is the norm, so baby steps it is!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116873/new/

https://reviews.llvm.org/D116873