[libcxx-commits] [PATCH] D116873: [libunwind][cmake] Create `LIBUNWIND_INSTALL_INCLUDE_DIR` CACHE PATH

Mon Jan 10 08:44:14 PST 2022

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.

================
Comment at: libunwind/CMakeLists.txt:157
 endif()
+set(LIBUNWIND_INSTALL_INCLUDE_DIR include CACHE PATH
+    "Path where built libunwind headers should be installed.")
----------------
A newline before this would be nice.

================
Comment at: libunwind/CMakeLists.txt:160
+set(LIBUNWIND_INSTALL_RUNTIME_DIR bin CACHE PATH
+    "Path where built libunwind runtime libraries should be installed.")

----------------
Perhaps it makes sense to use `CMAKE_INSTALL_INCLUDEDIR` and `CMAKE_INSTALL_BINDIR` to initialize the values?  That will allow the standard configuration paths to fold into this.  We could make these "advanced" and encourage users to prefer those (but retain these for the runtimes build configuration).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116873/new/

https://reviews.llvm.org/D116873