[libcxx-commits] [PATCH] D116344: [libc++] [ABI BREAK] Conform lognormal_distribution::param_type.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a subscriber: libc++ vendors.
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Okay, so the strategy here is:

1. We don't think this is going to break anyone.
2. We make the change unconditionally, and *perhaps* break some people, who will revert the change with the macro.
3. These people will comment here and we can adjust what we do based on that feedback.

I'm fine with this approach since I don't think anybody's going to be impacted -- IOW this is a small risk for an interesting benefit. FWIW, "these people" are most likely vendors who will discover any potential breakage through their users complaining over the next year or so, if that happens at all. If it does, we will make this a proper ABI macro and only enable it in the ABI-unstable build.

Pinging libc++ vendors to see if they have an opinion. @Quuxplusone please feel free to ship this at the end of this week if nobody has raised any concerns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116344/new/

https://reviews.llvm.org/D116344