[libcxx-commits] [PATCH] D116344: [libc++] [ABI BREAK] Conform lognormal_distribution::param_type.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/__random/lognormal_distribution.h:275-291
+template <class _CharT, class _Traits, class _RT>
+inline _LIBCPP_INLINE_VISIBILITY
+basic_ostream<_CharT, _Traits>&
+operator<<(basic_ostream<_CharT, _Traits>& __os,
+           const lognormal_distribution<_RT>& __x)
+{
+    return __os << __x.__nd_;
----------------
I was so tempted to make these hidden friends in the new code, but I didn't. ;)

The green code here is the same as what I was proposing in the previous diff. The changes between the `#if` and the `#else` blocks are minor, but many and scattered throughout, so I think this "one giant `#if`-`#else`" is the correct strategy here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116344/new/

https://reviews.llvm.org/D116344