[libcxx-commits] [PATCH] D116344: [libc++] [ABI BREAK] Conform lognormal_distribution::param_type.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 3 07:03:32 PST 2022


ldionne added a comment.

In D116344#3217496 <https://reviews.llvm.org/D116344#3217496>, @ldionne wrote:

> For these reasons, and because the behavior we're fixing is bad but also not like fixing basic functionality

What I mean here is that their code probably worked previously, and they had never noticed this bug. It's not like if `lognormal_distribution` had never worked properly and we were suddenly making it work -- I think an ABI break would be legit, cause nobody could really have been using it in the first place. Now this is sneakier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116344/new/

https://reviews.llvm.org/D116344



More information about the libcxx-commits mailing list