[libcxx-commits] [PATCH] D116344: [libc++] [ABI BREAK] Conform lognormal_distribution::param_type.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

These changes are hard. We don't have any way to tell whether it's going to bite someone, and chances are that it won't hurt anyone. But if it does, it's exactly the kind of thing that's going to be a huge pain to debug, and it's also going to be unfixable from their end once they find out what the issue is.

For these reasons, and because the behavior we're fixing is bad but also not like fixing basic functionality, I think it would be better to hide this behind an ABI macro.



================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval_param.PR52906.pass.cpp:14
+
+// template<class _URNG> result_type operator()(_URNG& g, const param_type& parm);
+
----------------
Please link to the bug report (using `llvm.org/PRXYZ`)


================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval_param.PR52906.pass.cpp:21
+
+int main()
+{
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116344/new/

https://reviews.llvm.org/D116344