[libcxx-commits] [PATCH] D116477: Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Looks sensible overall, modulo the typo.



================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:13
+
+  set(COMPILER_RT_SOURCE_DIR}"${CMAKE_CURRENT_SOURCE_DIR}/../..")
+
----------------
Stray `}`, missing a space?


================
Comment at: libcxx/CMakeLists.txt:16
 # Add path for custom modules
-set(CMAKE_MODULE_PATH
+list(INSERT CMAKE_MODULE_PATH 0
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
----------------
I presume this is fine (even if slightly unrelated) - I see that this aspect is inconsistent between runtimes today. It could be good to mention this in the commit message in any case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116477/new/

https://reviews.llvm.org/D116477