[libcxx-commits] [PATCH] D116477: Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 created this revision.
Ericson2314 added a reviewer: mstorsjo.
Herald added subscribers: libcxx-commits, mgorny.
Herald added a project: libunwind.
Herald added a reviewer: libunwind.
Ericson2314 requested review of this revision.
Herald added projects: Sanitizers, libc++, libc++abi.
Herald added a subscriber: Sanitizers.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

In D116472 <https://reviews.llvm.org/D116472> we created conditionally defined variables for the tools to
unbreak the legacy build where they are in `llvm/tools`.

The runtimes are not tools, so that flexibility doesn't matter. Still,
it might be nice to define (unconditionally) and use the variable for
the runtimes simply to make the code a bit clearer and document what is
going on.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116477

Files:
  compiler-rt/CMakeLists.txt
  compiler-rt/lib/builtins/CMakeLists.txt
  libcxx/CMakeLists.txt
  libcxxabi/CMakeLists.txt
  libunwind/CMakeLists.txt
  runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116477.396865.patch
Type: text/x-patch
Size: 4723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220101/ba1934e9/attachment-0001.bin>