[libcxx-commits] [PATCH] D120549: [libcxx] [test] Fix the monetary locale negative_sign test for en_US.UTF-8 on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D120549#3345680 <https://reviews.llvm.org/D120549#3345680>, @Quuxplusone wrote:

> Seems fine to me. My only suggestion is that I imagine there //must// be other tests that need updating in the same way for actually formatting negative numbers, like
>
>           Fwt f(LOCALE_en_US_UTF_8, 1);
>   #if defined(_WIN32)
>           assert(f.whateverformatmoney(-42) == L"(42)");
>   #else
>           assert(f.whateverformatmoney(-42) == L"-42");
>   #endif
>
> and maybe you could hit those tests in this same PR?

Yes, there’s actually a bunch of them. Unfortunately, some of them require a whole lot of churn in the tests, so I’m a bit undecided about some of them, whether it’s worth to fix them, or just change the XFAIL to a non-FIXME version, with an explanation. But this one seemed tolerable enough at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120549/new/

https://reviews.llvm.org/D120549