[libcxx-commits] [PATCH] D120549: [libcxx] [test] Fix the monetary locale negative_sign test for en_US.UTF-8 on Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

Seems fine to me. My only suggestion is that I imagine there //must// be other tests that need updating in the same way for actually formatting negative numbers, like

          Fwt f(LOCALE_en_US_UTF_8, 1);
  #if defined(_WIN32)
          assert(f.whateverformatmoney(-42) == L"(42)");
  #else
          assert(f.whateverformatmoney(-42) == L"-42");
  #endif

and maybe you could hit those tests in this same PR?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120549/new/

https://reviews.llvm.org/D120549