[libcxx-commits] [PATCH] D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS

Daniel McIntosh via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 24 12:56:18 PST 2022


DanielMcIntosh-IBM added inline comments.


================
Comment at: libcxx/src/include/internal_threading_support.h:70
+
+_LIBCPP_THREAD_ABI_VISIBILITY
+int __libcpp_recursive_mutex_init(__libcpp_recursive_mutex_t* __m) {
----------------
DanielMcIntosh-IBM wrote:
> Unlike `_VSTD::__libcpp_foo`, these are never provided by an external library, nor are the definitions ever used to build an external library, so they should probably always be inline and hidden from the ABI.
This will also probably fix the Windows CI failures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120348/new/

https://reviews.llvm.org/D120348



More information about the libcxx-commits mailing list