[libcxx-commits] [PATCH] D120348: [libcxx][SystemZ][ POSIX(OFF) support on z/OS

[Daniel McIntosh via Phabricator via libcxx-commits]

DanielMcIntosh-IBM accepted this revision.
DanielMcIntosh-IBM added inline comments.


================
Comment at: libcxx/src/include/internal_threading_support.h:54-58
+_LIBCPP_THREAD_ABI_VISIBILITY
+_LIBCPP_CONSTEXPR bool __libcpp_is_threading_api_enabled() { return true; }
+
+// Without any way of checking, we are forced to assume other threads have been spawned.
+_LIBCPP_THREAD_ABI_VISIBILITY
----------------
This is redundant because it's part of the forward declaration.


================
Comment at: libcxx/src/include/internal_threading_support.h:70
+
+_LIBCPP_THREAD_ABI_VISIBILITY
+int __libcpp_recursive_mutex_init(__libcpp_recursive_mutex_t* __m) {
----------------
Unlike `_VSTD::__libcpp_foo`, these are never provided by an external library, nor are the definitions ever used to build an external library, so they should probably always be inline and hidden from the ABI.


================
Comment at: libcxx/src/include/internal_threading_support.h:197
+    // TODO: Need a specific implementation for each platform which will allow
+    // __    libcpp_is_threading_api_enabled() to return false.
+    assert(0);
----------------



================
Comment at: libcxx/src/include/internal_threading_support.h:198
+    // __    libcpp_is_threading_api_enabled() to return false.
+    assert(0);
+#  endif
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120348/new/

https://reviews.llvm.org/D120348