[libcxx-commits] [PATCH] D120283: [libcxx] [test] Fix time.get.byname get_one for Glibc and Windows

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D120283#3337541 <https://reviews.llvm.org/D120283#3337541>, @Quuxplusone wrote:

> I'll let @Mordante accept, since I don't really know about locales. Looking at this test makes me think "What is even the point of standardized locales, if every platform is going to do them differently anyway?

I share that feeling. It's odd that a localized date looks different on Mac and Linux. I'm quite sure the people living in the region with that locale have a certain expectation how things look.

> But I'll just think of this as adding regression coverage, so that if the dumb behavior of Win/Linux/MacOS locales ever quietly changes, we'll be able to notice.

We already have some cases where the locale depends on the glibc version :-( Still I feel the test has value. We know we parse the input properly. Especially for dates like 12/2/2022, the 12th of February or the 2nd of December.

LGTM after addressing @Quuxplusone's comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120283/new/

https://reviews.llvm.org/D120283