[libcxx-commits] [PATCH] D120283: [libcxx] [test] Fix time.get.byname get_one for Glibc and Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

I'll let @Mordante accept, since I don't really know about locales. Looking at this test makes me think "What is even the point of standardized locales, if every platform is going to do them differently anyway? They don't enable //portable// code, that's for sure!" But I'll just think of this as adding //regression coverage//, so that if the dumb behavior of Win/Linux/MacOS locales ever quietly changes, we'll be able to notice.



================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp:129-130
+#ifdef TEST_HAS_GLIBC
+        const char in[] = "\xD0\xA1\xD0\xB1 31 \xD0\xB4\xD0\xB5\xD0\xBA"
+                          " 2061 23:55:59";
+#elif defined(_WIN32)
----------------
Prefer not to break up this string literal.


================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp:181-182
+#else
         const char in[] = "\xE5\x85\xAD"
                           " 12/31 23:55:59 2061";
+#endif
----------------
Pre-existing: Prefer not to break this one up either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120283/new/

https://reviews.llvm.org/D120283