[libcxx-commits] [PATCH] D119930: [libcxx] [test] Use proper UTF-8 locales on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.


================
Comment at: libcxx/test/libcxx/selftest/dsl/dsl.sh.py:223
+    """
+    def test_success(self):
+        source = """
----------------
ldionne wrote:
> Can you add a test checking that we raise `ConfigurationCompilationError` when we fail to compile the program? I.e. it's good to test that we don't swallow the error and return `False`.
Sure, will do!


================
Comment at: libcxx/utils/libcxx/test/features.py:81
+          #include <locale.h>
+          #include <ctype.h>
+          int main(int, char**) {
----------------
Mordante wrote:
> This header provides `towlower`.
Thanks, will fix before pushing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119930/new/

https://reviews.llvm.org/D119930