[libcxx-commits] [PATCH] D119930: [libcxx] [test] Use proper UTF-8 locales on Windows

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with test added. Also @Mordante had some comments, let's address those.



================
Comment at: libcxx/test/libcxx/selftest/dsl/dsl.sh.py:223
+    """
+    def test_success(self):
+        source = """
----------------
Can you add a test checking that we raise `ConfigurationCompilationError` when we fail to compile the program? I.e. it's good to test that we don't swallow the error and return `False`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119930/new/

https://reviews.llvm.org/D119930