[libcxx-commits] [PATCH] D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr

[Jinsong Ji via Phabricator via libcxx-commits]

jsji added inline comments.


================
Comment at: libcxx/test/libcxx/memory/trivial_abi/weak_ptr_ret.pass.cpp:54
+  // On AIX, structs are never returned in registers.
   // On ARM32, structs larger than 4 bytes cannot be returned in registers.
   // On Windows, structs with a destructor are always returned indirectly.
----------------
Quuxplusone wrote:
> This PR LGTM, but for what it's worth, I wonder whether `defined(__arm__)` might also be true on ARM64...
Thanks. @Quuxplusone.

I am not familiar with arm, it looks like to me that at least clang does not define `__arm__` for AArch64, it use `__aarch64__` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119952/new/

https://reviews.llvm.org/D119952