[libcxx-commits] [PATCH] D119952: [libc++][AIX] Fix trivial_abi return tests for unique_ptr/weak_ptr
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Feb 16 08:24:13 PST 2022
Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added inline comments.
================
Comment at: libcxx/test/libcxx/memory/trivial_abi/weak_ptr_ret.pass.cpp:54
+ // On AIX, structs are never returned in registers.
// On ARM32, structs larger than 4 bytes cannot be returned in registers.
// On Windows, structs with a destructor are always returned indirectly.
----------------
This PR LGTM, but for what it's worth, I wonder whether `defined(__arm__)` might also be true on ARM64...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119952/new/
https://reviews.llvm.org/D119952
More information about the libcxx-commits
mailing list