[libcxx-commits] [PATCH] D119177: [demangler] Fix buffer growth

Nathan Sidwell via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 16 07:31:10 PST 2022


urnathan added a comment.

In D119177#3326232 <https://reviews.llvm.org/D119177#3326232>, @thakis wrote:

> This breaks building on one of our bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8822094137116818625/+/u/package_clang/stdout?format=raw



> Looks like this now needs an include of `<algorithm>` for std::max(). That's a pretty heavy header though; maybe this should instead be rewritten to not use max, like on the lhs?

stupid inconsistent header files :), yeah algorithm is rather large, I'll open-code it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119177/new/

https://reviews.llvm.org/D119177



More information about the libcxx-commits mailing list