[libcxx-commits] [PATCH] D119177: [demangler] Fix buffer growth

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

This breaks building on one of our bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8822094137116818625/+/u/package_clang/stdout?format=raw

  In file included from /opt/s/w/ir/cache/builder/src/third_party/llvm/llvm/unittests/Demangle/ItaniumDemangleTest.cpp:9:
   In file included from /opt/s/w/ir/cache/builder/src/third_party/llvm/llvm/include/llvm/Demangle/ItaniumDemangle.h:25:
   /opt/s/w/ir/cache/builder/src/third_party/llvm/llvm/include/llvm/Demangle/Utility.h:42:19: error: no member named 'max' in namespace 'std'; did you mean 'fmax'?
         Need = std::max(Need, MinInitAlloc);
                ~~~~~^~~
                     fmax

Looks like this now needs an include of `<algorithm>` for std::max(). That's a pretty heavy header though; maybe this should instead be rewritten to not use max, like on the lhs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119177/new/

https://reviews.llvm.org/D119177