[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Mikael Holmén via Phabricator via libcxx-commits]

uabelho added a comment.

In D117174#3325739 <https://reviews.llvm.org/D117174#3325739>, @bjope wrote:

> In D117174#3325369 <https://reviews.llvm.org/D117174#3325369>, @uabelho wrote:
>
>> Any idea?
>
> I guess the new test ends up using clang-tidy from the PATH(?) rather than from the just built compiler. And that version might be too old if for example using llvm8.0 when building the compiler.
> So should perhaps the has-clang-tidy check be more picky about which version of clang-tidy that is found?

Indeed it seems like that. If I run the clang-tidy RUN line explicitly using clang-tidy from the clang installation used to build the compiler I get exactly the errors printed when running the lit test.

If I explicitly run the failing command explicitly using the newly built clang-tidy it works.

So in some way the wrong clang-tidy binary is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174