[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Bjorn Pettersson via Phabricator via libcxx-commits]

bjope added a comment.

In D117174#3325369 <https://reviews.llvm.org/D117174#3325369>, @uabelho wrote:

> HI,
>
> No idea what's happening but I get this error on trunk
>
>   FAIL: libc++ :: libcxx/clang_tidy.sh.cpp (600 of 7776)
>   ******************** TEST 'libc++ :: libcxx/clang_tidy.sh.cpp' FAILED ********************
>   Script:
>   --
>   : 'RUN: at line 11';   clang-tidy /repo/uabelho/master-github/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option -nostdinc++ -isystem /repo/uabelho/master-github/llvm/build-all-builtins/include/x86_64-unknown-linux-gnu/c++/v1 -isystem /repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1 -I/repo/uabelho/master-github/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/repo/uabelho/master-github/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
>   --
>   Exit Code: 1
>   
>   Command Output (stdout):
>   --
>   $ ":" "RUN: at line 11"
>   note: command had no output on stdout or stderr
>   $ "clang-tidy" "/repo/uabelho/master-github/libcxx/test/libcxx/clang_tidy.sh.cpp" "--warnings-as-errors=*" "-header-filter=.*" "--" "-Wno-unknown-warning-option" "-nostdinc++" "-isystem" "/repo/uabelho/master-github/llvm/build-all-builtins/include/x86_64-unknown-linux-gnu/c++/v1" "-isystem" "/repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1" "-I/repo/uabelho/master-github/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/libcxx/include/c++build" "-D__STDC_FORMAT_MACROS" "-D__STDC_LIMIT_MACROS" "-D__STDC_CONSTANT_MACROS" "-I/repo/uabelho/master-github/libcxx/test/support" "-std=c++2b" "-Werror" "-Wall" "-Wextra" "-Wshadow" "-Wundef" "-Wno-unused-command-line-argument" "-Wno-attributes" "-Wno-pessimizing-move" "-Wno-c++11-extensions" "-Wno-user-defined-literals" "-Wno-noexcept-type" "-Wno-atomic-alignment" "-Wsign-compare" "-Wunused-variable" "-Wunused-parameter" "-Wunreachable-code" "-Wno-unused-local-typedef" "-D_LIBCPP_DISABLE_AVAILABILITY" "-fcoroutines-ts" "-Werror=thread-safety" "-Wuser-defined-warnings" "-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER"
>   # command output:
>   error: invalid value 'c++2b' in '-std=c++2b' [clang-diagnostic-error]
>   note: use 'c++98' or 'c++03' for 'ISO C++ 1998 with amendments' standard
>   note: use 'gnu++98' or 'gnu++03' for 'ISO C++ 1998 with amendments and GNU extensions' standard
>   note: use 'c++11' for 'ISO C++ 2011 with amendments' standard
>   note: use 'gnu++11' for 'ISO C++ 2011 with amendments and GNU extensions' standard
>   note: use 'c++14' for 'ISO C++ 2014 with amendments' standard
>   note: use 'gnu++14' for 'ISO C++ 2014 with amendments and GNU extensions' standard
>   note: use 'c++17' for 'ISO C++ 2017 with amendments' standard
>   note: use 'gnu++17' for 'ISO C++ 2017 with amendments and GNU extensions' standard
>   note: use 'c++2a' for 'Working draft for ISO C++ 2020' standard
>   note: use 'gnu++2a' for 'Working draft for ISO C++ 2020 with GNU extensions' standard
>   /repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1/type_traits:4092:58: error: use of undeclared identifier '__builtin_is_constant_evaluated'; did you mean '__libcpp_is_constant_evaluated'? [clang-diagnostic-error]
>   bool __libcpp_is_constant_evaluated() _NOEXCEPT { return __builtin_is_constant_evaluated(); }
>                                                            ^
>   /repo/uabelho/master-github/llvm/build-all-builtins/include/c++/v1/type_traits:4092:6: note: '__libcpp_is_constant_evaluated' declared here
>   bool __libcpp_is_constant_evaluated() _NOEXCEPT { return __builtin_is_constant_evaluated(); }
>        ^
>   
>   # command stderr:
>   YAML:1:22: error: unknown key 'InheritParentConfig'
>   InheritParentConfig: true
>                        ^~~~
>   Error parsing /repo/uabelho/master-github/libcxx/.clang-tidy: Invalid argument
>   YAML:1:22: error: unknown key 'InheritParentConfig'
>   InheritParentConfig: true
>                        ^~~~
>   Error parsing /repo/uabelho/master-github/llvm/.clang-tidy: Invalid argument
>   25374 warnings and 2 errors generated.
>   Error while processing /repo/uabelho/master-github/libcxx/test/libcxx/clang_tidy.sh.cpp.
>   Suppressed 25374 warnings (25374 in non-user code).
>   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
>   Found compiler error(s).
>   
>   error: command failed with exit status: 1
>
> Any idea?

I guess the new test ends up using clang-tidy from the PATH(?) rather than from the just built compiler. And that version might be too old if for example using llvm8.0 when building the compiler.
So should perhaps the has-clang-tidy check be more picky about which version of clang-tidy that is found?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174