[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 15 13:21:41 PST 2022
philnik added inline comments.
================
Comment at: libcxx/utils/libcxx/test/features.py:86-87
when=lambda cfg: runScriptExitCode(cfg, ['%{exec} bash -c \'bash --version\'']) != 0),
+ Feature(name='has-clang-tidy',
+ when=lambda cfg: runScriptExitCode(cfg, ['clang-tidy --version']) == 0),
----------------
Quuxplusone wrote:
> The only remaining thing to keep me up at night is: How sure can we be that this feature is ever enabled? Would we notice if `has-clang-tidy` were //never// true on //any// buildbot?
>
> No action required, I'm just curious if anyone has a reassuring answer.
I guess people would notice if the tests fail locally, but all CI runs pass. But I don't think there is any guarantee.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117174/new/
https://reviews.llvm.org/D117174
More information about the libcxx-commits
mailing list