[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/utils/libcxx/test/features.py:86-87
           when=lambda cfg: runScriptExitCode(cfg, ['%{exec} bash -c \'bash --version\'']) != 0),
+  Feature(name='has-clang-tidy',
+          when=lambda cfg: runScriptExitCode(cfg, ['clang-tidy --version']) == 0),
 
----------------
The only remaining thing to keep me up at night is: How sure can we be that this feature is ever enabled? Would we notice if `has-clang-tidy` were //never// true on //any// buildbot?

No action required, I'm just curious if anyone has a reassuring answer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174