[libcxx-commits] [PATCH] D119790: [libcxx] [test] Fix the locale get_one_wide test for windows and glibc

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D119790#3323316 <https://reviews.llvm.org/D119790#3323316>, @Mordante wrote:

> SGTM but I'd like to understand why `tm_wday` can't be tested on Windows.

Those tests try to parse a date string in a format that corresponds to what `strftime("%c")` produces. On Windows, the `%c` time format lacks the leading week day, which means that we must omit it from the input text string in the test, and after parsing it, `tm_wday` isn't filled in as it wasn't part of the string. I guess I should add a comment that explains this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119790/new/

https://reviews.llvm.org/D119790