[libcxx-commits] [PATCH] D119790: [libcxx] [test] Fix the locale get_one_wide test for windows and glibc

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 15 09:04:07 PST 2022


Mordante added a comment.

SGTM but I'd like to understand why `tm_wday` can't be tested on Windows.



================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp:68
         assert(t.tm_year == 161);
+#ifndef _WIN32
         assert(t.tm_wday == 6);
         assert(err == std::ios_base::eofbit);
----------------
Does Windows lack this tm member? If so please add a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119790/new/

https://reviews.llvm.org/D119790



More information about the libcxx-commits mailing list