[libcxx-commits] [PATCH] D119445: [libc++] Use std::ranges::swap_ranges in swap CPO

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

This LGTM, however I would like to see this again after rebasing on top of D118736 <https://reviews.llvm.org/D118736>. D118736 <https://reviews.llvm.org/D118736> is a must-have, and I think both are going to be in conflict, so we might have to postpone doing this. Or we could do something like:

  #if defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
    // use for loop
  #else
    // use ranges::swap_ranges
  #endif

Once we stop using `_LIBCPP_HAS_NO_INCOMPLETE_RANGES`, we can refactor this into only the `#else` branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119445/new/

https://reviews.llvm.org/D119445